Issue 2563: Fix SST file corruption. #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The record is sent asynchronously. We need to use a copy of the passed buffer in the record. The ownership is retained by the caller and will be potentially changed by the caller. In case of corruption the later blocks were overwritting the previous blocks resulting in corruption
merlimat
approved these changes
Jan 29, 2021
|
@dlg99 we are using the dev/bk-merge-pr.py script in order to merge and cherry pick. Feel free to commit as soon as CI passes. We should cherry pick to branch-4.12 branch-4.11 and branch-4.10 |
dlg99
pushed a commit
that referenced
this pull request
Feb 2, 2021
Fix SST File corruption during checkpointing ### Motivation Since the SST files are shared among checkpoints, this will not be resolved by future checkpoints. We will fail to restore all future checkpoints that depend on this file. ### Changes The record is sent asynchronously. We need to use a copy of the passed buffer in the record. The ownership is retained by the caller and will be potentially changed by the caller. In case of corruption the later blocks were overwriting the previous blocks resulting in corruption Master Issue: #2563 Reviewers: Andrey Yegorov <None>, Enrico Olivelli <eolivelli@gmail.com>, Matteo Merli <mmerli@apache.org> This closes #2564 from sursingh/fix-sst-corruption, closes #2563
dlg99
pushed a commit
that referenced
this pull request
Feb 2, 2021
Fix SST File corruption during checkpointing ### Motivation Since the SST files are shared among checkpoints, this will not be resolved by future checkpoints. We will fail to restore all future checkpoints that depend on this file. ### Changes The record is sent asynchronously. We need to use a copy of the passed buffer in the record. The ownership is retained by the caller and will be potentially changed by the caller. In case of corruption the later blocks were overwriting the previous blocks resulting in corruption Master Issue: #2563 Reviewers: Andrey Yegorov <None>, Enrico Olivelli <eolivelli@gmail.com>, Matteo Merli <mmerli@apache.org> This closes #2564 from sursingh/fix-sst-corruption, closes #2563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SST File corruption during checkpointing
Motivation
Since the SST files are shared among checkpoints, this will not be resolved by future checkpoints. We will fail to restore all future checkpoints that depend on this file.
Changes
The record is sent asynchronously. We need to use a copy of the passed buffer
in the record. The ownership is retained by the caller and will be potentially
changed by the caller. In case of corruption the later blocks were
overwriting the previous blocks resulting in corruption
Master Issue: #2563